]> granicus.if.org Git - postgresql/commit
Remove lappend_cell...() family of List functions.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 16 Jul 2019 17:12:24 +0000 (13:12 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 16 Jul 2019 17:12:24 +0000 (13:12 -0400)
commitc245776906b065fcd59831a25c3b24ad3ddcd849
tree7bcc6c8dc1d4960e65592726a662d5952b318e3c
parent2f5b8eb5a28b4e6de9d20cc7d2c6028c6c7a8aa8
Remove lappend_cell...() family of List functions.

It seems worth getting rid of these functions because they require the
caller to retain a ListCell pointer into a List that it's modifying,
which is a dangerous practice with the new List implementation.
(The only other List-modifying function that takes a ListCell pointer
as input is list_delete_cell, which nowadays is preferentially used
via the constrained API foreach_delete_current.)

There was only one remaining caller of these functions after commit
2f5b8eb5a, and that was some fairly ugly GEQO code that can be much
more clearly expressed using a list-index variable and list_insert_nth.
Hence, rewrite that code, and remove the functions.

Discussion: https://postgr.es/m/26193.1563228600@sss.pgh.pa.us
src/backend/nodes/list.c
src/backend/optimizer/geqo/geqo_eval.c
src/include/nodes/pg_list.h