]> granicus.if.org Git - cgit/commit
parsing: clear query path before starting
authorJohn Keeping <john@keeping.me.uk>
Sun, 19 Feb 2017 12:17:05 +0000 (12:17 +0000)
committerLukas Fleischer <lfleischer@lfos.de>
Thu, 10 Aug 2017 13:15:57 +0000 (15:15 +0200)
commitc0d2423f07099366815856500faec3a69db1701a
tree6b63a3b2f28a1d3f7a7039c47bed246c24a87362
parentfdcd7dc8186e8d928876ae858b7d2d3a87d29453
parsing: clear query path before starting

By specifying the "url" query parameter multiple times it is possible to
end up with ctx.qry.vpath set while ctx.repo is null, which triggers an
invalid code path from cgit_print_pageheader() while printing path
crumbs, resulting in a null dereference.

The previous patch fixed this segfault, but it makes no sense for us to
clear ctx.repo while leaving ctx.qry.path set to the previous value, so
let's just clear it here so that the last "url" parameter given takes
full effect rather than partially overriding the effect of the previous
value.

Signed-off-by: John Keeping <john@keeping.me.uk>
parsing.c