Fix minor oversights in nodeAgg.c.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 21 Dec 2016 00:22:02 +0000 (19:22 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 21 Dec 2016 00:22:02 +0000 (19:22 -0500)
commitc080b223a7a3991524a5287416a0ad756c15a098
tree7c7334a3451239834699ada80dee0943a22576f8
parent7d41a2bd3eef4de64ae8f6f683457f12f9407c5d
Fix minor oversights in nodeAgg.c.

aggstate->evalproj is always set up by ExecInitAgg, so there's no
need to test.  Doing so led Coverity to think that we might be
intending "slot" to be possibly NULL here, and it quite properly
complained that the rest of combine_aggregates() wasn't prepared
for that.

Also fix a couple of obvious thinkos in Asserts checking that
"inputoff" isn't past the end of the slot.

Errors introduced in commit 8ed3f11bb, so no need for back-patch.
src/backend/executor/nodeAgg.c