]> granicus.if.org Git - llvm/commit
Improve Aliasing of operations to static alloca
authorNirav Dave <niravd@google.com>
Fri, 14 Jul 2017 13:56:21 +0000 (13:56 +0000)
committerNirav Dave <niravd@google.com>
Fri, 14 Jul 2017 13:56:21 +0000 (13:56 +0000)
commitbe4d3e6292364def4a7d61e3b53246c5fe8a355a
tree3f49656252b465fb06312239ae38885749c47a7c
parent7392b5ac28a791852995ebe2bf5f66cc3dbedc8a
Improve Aliasing of operations to static alloca

Recommiting after adding check to avoid miscomputing alias information
on addresses of the same base but different subindices.

Memory accesses offset from frame indices may alias, e.g., we
may merge write from function arguments passed on the stack when they
are contiguous. As a result, when checking aliasing, we consider the
underlying frame index's offset from the stack pointer.

Static allocs are realized as stack objects in SelectionDAG, but its
offset is not set until post-DAG causing DAGCombiner's alias check to
consider access to static allocas to frequently alias. Modify isAlias
to consider access between static allocas and access from other frame
objects to be considered aliasing.

Many test changes are included here. Most are fixes for tests which
indirectly relied on our aliasing ability and needed to be modified to
preserve their original intent.

The remaining tests have minor improvements due to relaxed
ordering. The exception is CodeGen/X86/2011-10-19-widen_vselect.ll
which has a minor degradation dispite though the pre-legalized DAG is
improved.

Reviewers: rnk, mkuper, jonpa, hfinkel, uweigand

Reviewed By: rnk

Subscribers: sdardis, nemanjai, javed.absar, llvm-commits

Differential Revision: https://reviews.llvm.org/D33345

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@308025 91177308-0d34-0410-b5e6-96231b3b80d8
24 files changed:
lib/CodeGen/SelectionDAG/DAGCombiner.cpp
test/CodeGen/AArch64/arm64-abi-varargs.ll
test/CodeGen/AArch64/arm64-abi_align.ll
test/CodeGen/AArch64/arm64-alloca-frame-pointer-offset.ll
test/CodeGen/AArch64/arm64-vext.ll
test/CodeGen/AArch64/dag-combine-invaraints.ll
test/CodeGen/AArch64/swifterror.ll
test/CodeGen/ARM/atomic-op.ll
test/CodeGen/MSP430/vararg.ll
test/CodeGen/Mips/dins.ll
test/CodeGen/X86/2011-10-19-widen_vselect.ll
test/CodeGen/X86/alias-static-alloca.ll [new file with mode: 0644]
test/CodeGen/X86/clobber-fi0.ll
test/CodeGen/X86/hipe-cc.ll
test/CodeGen/X86/hipe-cc64.ll
test/CodeGen/X86/legalize-shift-64.ll
test/CodeGen/X86/machine-outliner-debuginfo.ll
test/CodeGen/X86/machine-outliner.ll
test/CodeGen/X86/statepoint-invoke.ll
test/CodeGen/X86/statepoint-stack-usage.ll
test/CodeGen/X86/statepoint-vector.ll
test/CodeGen/X86/widen_arith-2.ll
test/CodeGen/X86/widen_cast-4.ll
test/CodeGen/XCore/varargs.ll