]> granicus.if.org Git - postgresql/commit
Fix multiple minor infelicities in aclchk.c error reports.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 13 Jun 2016 17:53:10 +0000 (13:53 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 13 Jun 2016 17:53:10 +0000 (13:53 -0400)
commitbdf39b2c577a107063dfbbe398ff77c5b65ba731
tree4f243215edff523653f54220c3f90c8139a472cf
parentcbd72c72b0ac5f829538b8d96d35288626db1ff8
Fix multiple minor infelicities in aclchk.c error reports.

pg_type_aclmask reported the wrong type's OID when complaining that
it could not find a type's typelem.  It also failed to provide a
suitable errcode when the initially given OID doesn't exist (which
is a user-facing error, since that OID can be user-specified).
pg_foreign_data_wrapper_aclmask and pg_foreign_server_aclmask likewise
lacked errcode specifications.  Trivial cosmetic adjustments too.

The wrong-type-OID problem was reported by Petru-Florin Mihancea in
bug #14186; the other issues noted by me while reading the code.
These errors all seem to be aboriginal in the respective routines, so
back-patch as necessary.

Report: <20160613163159.5798.52928@wrigleys.postgresql.org>
src/backend/catalog/aclchk.c