]> granicus.if.org Git - postgresql/commit
On Windows, make pg_dump use binary mode for compressed plain text output.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 19 Jun 2017 15:02:45 +0000 (11:02 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 19 Jun 2017 15:02:45 +0000 (11:02 -0400)
commitbd61d5a194ac24f0c282ed414e1378846f78dee4
treea44ae40d5b4df7f0c26770739968c8a15b81c0e0
parent3bdea167eb01491a4898e977d308508374e97bfa
On Windows, make pg_dump use binary mode for compressed plain text output.

The combination of -Z -Fp and output to stdout resulted in corrupted
output data, because we left stdout in text mode, resulting in newline
conversion being done on the compressed stream.  Switch stdout to binary
mode for this case, at the same place where we do it for non-text output
formats.

Report and patch by Kuntal Ghosh, tested by Ashutosh Sharma and Neha
Sharma.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/CAGz5QCJPvbBjXAmJuGx1B_41yVCetAJhp7rtaDf7XQGWuB1GSw@mail.gmail.com
src/bin/pg_dump/pg_backup_archiver.c