]> granicus.if.org Git - postgresql/commit
In the pg_upgrade test suite, don't write to src/test/regress.
authorNoah Misch <noah@leadboat.com>
Sun, 19 May 2019 21:36:44 +0000 (14:36 -0700)
committerNoah Misch <noah@leadboat.com>
Sun, 19 May 2019 21:36:44 +0000 (14:36 -0700)
commitbd1592e8570282b1650af6b8eede0016496daecd
tree8f335da3774f1057e67a01efb04a6372d32da0e7
parent9d5c22d28f8c161aa729d841aeec936c646044d4
In the pg_upgrade test suite, don't write to src/test/regress.

When this suite runs installcheck, redirect file creations from
src/test/regress to src/bin/pg_upgrade/tmp_check/regress.  This closes a
race condition in "make -j check-world".  If the pg_upgrade suite wrote
to a given src/test/regress/results file in parallel with the regular
src/test/regress invocation writing it, a test failed spuriously.  Even
without parallelism, in "make -k check-world", the suite finishing
second overwrote the other's regression.diffs.  This revealed test
"largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.

Buildfarm client REL_10, released forty-five days ago, supports saving
regression.diffs from its new location.  When an older client reports a
pg_upgradeCheck failure, it will no longer include regression.diffs.
Back-patch to 9.5, where pg_upgrade moved to src/bin.

Reviewed by Andrew Dunstan.

Discussion: https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
src/bin/pg_upgrade/test.sh
src/test/regress/input/largeobject.source
src/test/regress/output/largeobject.source
src/test/regress/output/largeobject_1.source
src/tools/msvc/vcregress.pl