]> granicus.if.org Git - llvm/commit
Disable tidy checks with too many hits
authorIlya Biryukov <ibiryukov@google.com>
Fri, 1 Feb 2019 11:20:13 +0000 (11:20 +0000)
committerIlya Biryukov <ibiryukov@google.com>
Fri, 1 Feb 2019 11:20:13 +0000 (11:20 +0000)
commitba3936b0ea89935ab8ea943c1b372d69923691d9
tree634ccd70d40ed9a7b91c8add75a93701f62c240d
parent58de8603ab01ef0331ecb221a17d3124e80b1749
Disable tidy checks with too many hits

Summary:
Some tidy checks have too many hits in the codebase, making it hard to spot
other results from clang-tidy, therefore rendering the tool less useful.

Two checks were disabled:
  - misc-non-private-member-variable-in-classes in the whole LLVM monorepo,
    it is very common to have those in LLVM and the style guide does not forbid
    them.
  - readability-identifier-naming in the clang subtree. There are thousands of
    violations in 'Sema.h' alone.

Before the change, 'Sema.h' had >1000 tidy warnings, after the change the number
dropped to 3 warnings (unterminated namespace comments).

Reviewers: alexfh, hokein

Reviewed By: hokein

Subscribers: llvm-commits, cfe-commits

Tags: #clang, #llvm

Differential Revision: https://reviews.llvm.org/D57573

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@352862 91177308-0d34-0410-b5e6-96231b3b80d8
.clang-tidy