]> granicus.if.org Git - graphviz/commit
fix incorrect reference counting of interned HTML strings
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Sat, 20 Mar 2021 19:31:43 +0000 (12:31 -0700)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Mon, 29 Mar 2021 00:00:53 +0000 (17:00 -0700)
commitb9c3b046ca4ee59172e57cc23f70a1e432af258b
tree436529a0e51ea23d6cf867f57ff9d5a95b7e0b75
parent27fdac8a05e479d69403bcafcb432f80c3ec679a
fix incorrect reference counting of interned HTML strings

This typo meant that, instead of masking the reference counting bits, this check
was also including the HTML bit (bit 31). As a result, interned HTML strings
would never be freed. This was found by an introduced -Wlogical-op warning when
building an upcoming change with GCC 8.3.0.
CHANGELOG.md
lib/cgraph/refstr.c