]> granicus.if.org Git - postgresql/commit
In Windows pg_dump, ensure idle workers will shut down during error exit.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 26 May 2016 14:50:30 +0000 (10:50 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 26 May 2016 14:50:46 +0000 (10:50 -0400)
commitb9784e1f769497dcfaa1f866913f3d86a2adf176
tree2237703b18ec87300ec099307c1d9ea24a7a9725
parent6537a48c5521cb2fc401e18fe678633a688965b5
In Windows pg_dump, ensure idle workers will shut down during error exit.

The Windows coding of ShutdownWorkersHard() thought that setting termEvent
was sufficient to make workers exit after an error.  But that only helps
if a worker is busy and passes through checkAborting().  An idle worker
will just sit, resulting in pg_dump failing to exit until the user gives up
and hits control-C.  We should close the write end of the command pipe
so that idle workers will see socket EOF and exit, as the Unix coding was
already doing.

Back-patch to 9.3 where parallel pg_dump was introduced.

Kyotaro Horiguchi
src/bin/pg_dump/parallel.c