]> granicus.if.org Git - postgresql/commit
Fix some coding issues in BRIN
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Sat, 8 Nov 2014 03:31:03 +0000 (00:31 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Sat, 8 Nov 2014 03:31:03 +0000 (00:31 -0300)
commitb89ee54e20e722bb91f388667586a2e0986f197b
tree896df39d9e413e9cc9b59847a6fa60b84de4b73c
parent926f5cea472676b8378f02cd80c2c5f86226d981
Fix some coding issues in BRIN

Reported by David Rowley: variadic macros are a problem.  Get rid of
them using a trick suggested by Tom Lane: add extra parentheses where
needed.  In the future we might decide we don't need the calls at all
and remove them, but it seems appropriate to keep them while this code
is still new.

Also from David Rowley: brininsert() was trying to use a variable before
initializing it.  Fix by moving the brin_form_tuple call (which
initializes the variable) to within the locked section.

Reported by Peter Eisentraut: can't use "new" as a struct member name,
because C++ compilers will choke on it, as reported by cpluspluscheck.
src/backend/access/brin/brin.c
src/backend/access/brin/brin_pageops.c
src/backend/access/brin/brin_revmap.c
src/backend/access/brin/brin_xlog.c
src/backend/access/rmgrdesc/brindesc.c
src/include/access/brin_internal.h
src/include/access/brin_xlog.h