]> granicus.if.org Git - postgresql/commit
Avoid double-free in vacuumlo error path.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 24 Mar 2019 19:13:21 +0000 (15:13 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 24 Mar 2019 19:13:21 +0000 (15:13 -0400)
commitb7ffa0ee8d55af0eb236d7496853c38c266d96d5
treed0c7b7e293cd4b19ef7eb2c2829962f14b10b0c8
parent89f39736f4845e81f350893dd59fd52cedab8b39
Avoid double-free in vacuumlo error path.

The code would do "PQclear(res)" twice if lo_unlink failed, evidently
due to careless thinking about how far out a "break" would break.
Remove the extra PQclear and adjust the loop logic so that we'll fall
out of both levels of loop after an error, as was clearly the intent.

Spotted by Coverity.  I have no idea why it took this long to notice,
since the bug has been there since commit 67ccbb080.  Accordingly,
back-patch to all supported branches.
contrib/vacuumlo/vacuumlo.c