]> granicus.if.org Git - postgresql/commit
pg_dump: Fix dumping of WITH OIDS tables
authorPeter Eisentraut <peter_e@gmx.net>
Fri, 9 Nov 2018 08:17:25 +0000 (09:17 +0100)
committerPeter Eisentraut <peter_e@gmx.net>
Tue, 13 Nov 2018 08:41:34 +0000 (09:41 +0100)
commitb72b4fafb962c5cc1c3d2311b2971a299497202b
tree331869101f56a2647087ffdb6119fa68d83e6e6e
parentf43e679b533cab0f26adbca8d54585b94889ce80
pg_dump: Fix dumping of WITH OIDS tables

A table with OIDs that was the first in the dump output would not get
dumped with OIDs enabled.  Fix that.

The reason was that the currWithOids flag was declared to be bool but
actually also takes a -1 value for "don't know yet".  But under
stdbool.h semantics, that is coerced to true, so the required SET
default_with_oids command is not output again.  Change the variable
type to char to fix that.

Reported-by: Derek Nelson <derek@pipelinedb.com>
src/bin/pg_dump/pg_backup_archiver.h