]> granicus.if.org Git - python/commit
bpo-28134: Auto-detect socket values from file descriptor (#1349)
authorChristian Heimes <christian@python.org>
Mon, 29 Jan 2018 21:37:58 +0000 (22:37 +0100)
committerGitHub <noreply@github.com>
Mon, 29 Jan 2018 21:37:58 +0000 (22:37 +0100)
commitb6e43af669f61a37a29d8ff0785455108e6bc29d
tree3a6c733b60cf579c43b18cabdc9a7a3ce113f81b
parent72a0d218dcc94a3cc409a9ef32dfcd5a7bbcb43c
bpo-28134: Auto-detect socket values from file descriptor (#1349)

Fix socket(fileno=fd) by auto-detecting the socket's family, type,
and proto from the file descriptor. The auto-detection can be overruled
by passing in family, type, and proto explicitly.

Without the fix, all socket except for TCP/IP over IPv4 are basically broken:

>>> s = socket.create_connection(('www.python.org', 443))
>>> s
<socket.socket fd=3, family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=6, laddr=('2003:58:bc4a:3b00:56ee:75ff:fe47:ca7b', 59730, 0, 0), raddr=('2a04:4e42:1b::223', 443, 0, 0)>
>>> socket.socket(fileno=s.fileno())
<socket.socket fd=3, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('2003:58:bc4a:3b00::%2550471192', 59730, 0, 2550471192), raddr=('2a04:4e42:1b:0:700c:e70b:ff7f:0%2550471192', 443, 0, 2550471192)>

Signed-off-by: Christian Heimes <christian@python.org>
Doc/library/socket.rst
Lib/socket.py
Lib/test/_test_multiprocessing.py
Lib/test/test_socket.py
Misc/NEWS.d/next/Library/2017-12-24-20-01-09.bpo-28134.HJ8Beb.rst [new file with mode: 0644]
Modules/socketmodule.c