]> granicus.if.org Git - postgresql/commit
Make src/common/exec.c's error logging less ugly.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 9 Oct 2018 17:36:16 +0000 (13:36 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 9 Oct 2018 17:36:24 +0000 (13:36 -0400)
commitb6b297d20df9f738be20a450f80bade535819220
tree3dfaf336eaa129b08662338bd50b27954c22a55a
parent36e9d413a1d6928cd809d302d495fd6880a44b1e
Make src/common/exec.c's error logging less ugly.

This code used elog where it really ought to use ereport, mainly so that
it can report a SQLSTATE different from ERRCODE_INTERNAL_ERROR.  There
were some other random deviations from typical error report practice too.

In addition, we can make some cleanups that were impractical six months
ago:

* Use one variadic macro, instead of several with different numbers
of arguments, reducing the temptation to force-fit messages into
particular numbers of arguments;

* Use %m, even in the frontend case, simplifying the code.

Discussion: https://postgr.es/m/6025.1527351693@sss.pgh.pa.us
src/common/exec.c