]> granicus.if.org Git - postgresql/commit
De-support floating-point timestamps.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 23 Feb 2017 16:40:12 +0000 (11:40 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 23 Feb 2017 16:40:20 +0000 (11:40 -0500)
commitb6aa17e0ae367afdcea07118e016111af4fa6bc3
tree54079153effacb688e0d34af0459a9205dc041c0
parentc3368f9173c13e2e293df91f75f1a5c565c4ca18
De-support floating-point timestamps.

Per discussion, the time has come to do this.  The handwriting has been
on the wall at least since 9.0 that this would happen someday, whenever
it got to be too much of a burden to support the float-timestamp option.
The triggering factor now is the discovery that there are multiple bugs
in the code that attempts to implement use of integer timestamps in the
replication protocol even when the server is built for float timestamps.
The internal float timestamps leak into the protocol fields in places.
While we could fix the identified bugs, there's a very high risk of
introducing more.  Trying to build a wall that would positively prevent
mixing integer and float timestamps is more complexity than we want to
undertake to maintain a long-deprecated option.  The fact that these
bugs weren't found through testing also indicates a lack of interest
in float timestamps.

This commit disables configure's --disable-integer-datetimes switch
(it'll still accept --enable-integer-datetimes, though), removes direct
references to USE_INTEGER_DATETIMES, and removes discussion of float
timestamps from the user documentation.  A considerable amount of code is
rendered dead by this, but removing that will occur as separate mop-up.

Discussion: https://postgr.es/m/26788.1487455319@sss.pgh.pa.us
15 files changed:
configure
configure.in
doc/src/sgml/config.sgml
doc/src/sgml/datatype.sgml
doc/src/sgml/installation.sgml
src/include/c.h
src/include/pg_config.h.in
src/include/pg_config.h.win32
src/interfaces/ecpg/include/ecpg_config.h.in
src/interfaces/ecpg/include/pgtypes_interval.h
src/interfaces/ecpg/test/expected/pgtypeslib-dt_test2.c
src/interfaces/ecpg/test/expected/pgtypeslib-dt_test2.stdout
src/interfaces/ecpg/test/pgtypeslib/dt_test2.pgc
src/tools/msvc/Solution.pm
src/tools/msvc/config_default.pl