]> granicus.if.org Git - postgresql/commit
Be sure to close() file descriptor on error case
authorStephen Frost <sfrost@snowman.net>
Sun, 14 Jul 2013 21:25:47 +0000 (17:25 -0400)
committerStephen Frost <sfrost@snowman.net>
Sun, 14 Jul 2013 21:25:47 +0000 (17:25 -0400)
commitb68a1fc7ff1a50a7282e8edff7c51333274c3334
treee044c013eb32f0bb43c9e249d20da7d108d4710b
parente9010b992640d1dbf212cbbab40a00093515f16f
Be sure to close() file descriptor on error case

In receivelog.c:writeTimeLineHistoryFile(), we were not properly
closing the open'd file descriptor in error cases.  While this
wouldn't matter much if we were about to exit due to such an
error, that's not the case with pg_receivexlog as it can be a
long-running process and these errors are non-fatal.

This resource leak was found by the Coverity scanner.

Back-patch to 9.3 where this issue first appeared.
src/bin/pg_basebackup/receivelog.c