]> granicus.if.org Git - postgresql/commit
Further improvements to c8f621c43.
authorAndres Freund <andres@anarazel.de>
Mon, 7 Mar 2016 22:24:03 +0000 (14:24 -0800)
committerAndres Freund <andres@anarazel.de>
Mon, 7 Mar 2016 22:24:03 +0000 (14:24 -0800)
commitb63bea5fd3bba4d7a61c3beaba51a06f24b38da6
treef8bbb7871fe6f213fcec3df2c7cdba09370bb3d3
parent3fc6e2d7f5b652b417fa6937c34de2438d60fa9f
Further improvements to c8f621c43.

Coverity and inspection for the issue addressed in fd45d16f found some
questionable code.

Specifically coverity noticed that the wrong length was added in
ReorderBufferSerializeChange() - without immediate negative consequences
as the variable isn't used afterwards.  During code-review and testing I
noticed that a bit of space was wasted when allocating tuple bufs in
several places.  Thirdly, the debug memset()s in
ReorderBufferGetTupleBuf() reduce the error checking valgrind can do.

Backpatch: 9.4, like c8f621c43.
src/backend/replication/logical/decode.c
src/backend/replication/logical/reorderbuffer.c