]> granicus.if.org Git - postgresql/commit
Ensure default-only storage parameters for TOAST relations
authorItagaki Takahiro <itagaki.takahiro@gmail.com>
Mon, 7 Jun 2010 02:59:02 +0000 (02:59 +0000)
committerItagaki Takahiro <itagaki.takahiro@gmail.com>
Mon, 7 Jun 2010 02:59:02 +0000 (02:59 +0000)
commitb5faba1284c4e5108c6fbe577daa33f933e7a4e0
tree86bb121d206f9369e8d744414c339826e1a54d83
parent3fd839950a33a7d36ac83edf1f9cc6fb929d7649
Ensure default-only storage parameters for TOAST relations
to be initialized with proper values. Affected parameters are
fillfactor, analyze_threshold, and analyze_scale_factor.

Especially uninitialized fillfactor caused inefficient page usage
because we built a StdRdOptions struct in which fillfactor is zero
if any reloption is set for the toast table.

In addition, we disallow toast.autovacuum_analyze_threshold and
toast.autovacuum_analyze_scale_factor because we didn't actually
support them; they are always ignored.

Report by Rumko on pgsql-bugs on 12 May 2010.
Analysis by Tom Lane and Alvaro Herrera. Patch by me.

Backpatch to 8.4.
doc/src/sgml/ref/create_table.sgml
src/backend/access/common/reloptions.c
src/bin/psql/tab-complete.c