]> granicus.if.org Git - llvm/commit
[llvm] Revert r231274: "Devirtualize ~parser<T> by making it protected in base classe...
authorDon Hinton <hintonda@gmail.com>
Fri, 3 May 2019 16:15:13 +0000 (16:15 +0000)
committerDon Hinton <hintonda@gmail.com>
Fri, 3 May 2019 16:15:13 +0000 (16:15 +0000)
commitb5f456a009db6764a954f6f23060ebada8ef9a98
treefe1b32aa2726009129dfa0993573d41d1b416e78
parenta3b81fe4c3b89a82dcfe48949c0c4b08642dfd5a
[llvm] Revert r231274: "Devirtualize ~parser<T> by making it protected in base classes and making derived classes final"

Summary: This patch was previously applied in r231221, and reverted in
r231254 because it broke self-hosting.  It was subsequently fixed and
reapplied in r231274.  Unfortunately, making the `parser<T>` classes
final prevents inheritance which makes it impossible to implement
custom parsers.

Reverting r231221 restores the ability to customize parsers.

Reviewers: dblaikie

Reviewed By: dblaikie

Subscribers: craig.topper, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D60955

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@359902 91177308-0d34-0410-b5e6-96231b3b80d8
include/llvm/Support/CommandLine.h