]> granicus.if.org Git - curl/commit
http: Ignore HTTP/2 prior knowledge setting for HTTP proxies
authorJay Satiro <raysatiro@yahoo.com>
Wed, 8 May 2019 07:39:53 +0000 (03:39 -0400)
committerJay Satiro <raysatiro@yahoo.com>
Thu, 9 May 2019 02:50:41 +0000 (22:50 -0400)
commitb5901cab574aa673b0b7195be501ab9492b3832b
treeb95ce39cf5d2aaef0ef71d15df75f964c4c12980
parent21d070a0cb3b980c94f72375e2d8553ad5403aec
http: Ignore HTTP/2 prior knowledge setting for HTTP proxies

- Do not switch to HTTP/2 for an HTTP proxy that is not tunnelling to
  the destination host.

We already do something similar for HTTPS proxies by not sending h2. [1]

Prior to this change setting CURL_HTTP_VERSION_2_PRIOR_KNOWLEDGE would
incorrectly use HTTP/2 to talk to the proxy, which is not something we
support (yet?). Also it's debatable whether or not that setting should
apply to HTTP/2 proxies.

[1]: https://github.com/curl/curl/commit/17c5d05

Bug: https://github.com/curl/curl/issues/3570
Bug: https://github.com/curl/curl/issues/3832

Closes https://github.com/curl/curl/pull/3853
lib/http.c