]> granicus.if.org Git - postgresql/commit
Avoid possibly-unsafe use of Windows' FormatMessage() function.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 29 Mar 2016 15:54:58 +0000 (11:54 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 29 Mar 2016 15:54:58 +0000 (11:54 -0400)
commitb4b06931ed22e9a38442b16676aaf16ace92bf8d
tree15f3c76110098c24fc26f51dbc61d1fe694ad8f7
parent4edcd5f5d23c55f60d6c11451437437611731fff
Avoid possibly-unsafe use of Windows' FormatMessage() function.

Whenever this function is used with the FORMAT_MESSAGE_FROM_SYSTEM flag,
it's good practice to include FORMAT_MESSAGE_IGNORE_INSERTS as well.
Otherwise, if the message contains any %n insertion markers, the function
will try to fetch argument strings to substitute --- which we are not
passing, possibly leading to a crash.  This is exactly analogous to the
rule about not giving printf() a format string you're not in control of.

Noted and patched by Christian Ullrich.
Back-patch to all supported branches.
src/backend/libpq/auth.c
src/backend/port/win32/socket.c
src/interfaces/libpq/fe-auth.c
src/port/dirmod.c