]> granicus.if.org Git - postgresql/commit
Fix unsafe reference into relcache in constructed CommentStmt.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 15 May 2017 15:33:44 +0000 (11:33 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 15 May 2017 15:33:44 +0000 (11:33 -0400)
commitb35cce914cd3eef7d4a2471073c80f709d724e5a
tree8741d05b4c572cb74b604f123f287bef6929f0b2
parentc4118d3b9bf4273a2877ea20ff6ccb337dbb5abf
Fix unsafe reference into relcache in constructed CommentStmt.

The CommentStmt made by RebuildConstraintComment() has to pstrdup the
relation name, else it will contain a dangling pointer after that
relcache entry is flushed.  (I'm less sure that pstrdup'ing conname
is necessary, but let's be safe.)  Failure to do this leads to weird
errors or crashes, as reported by Marko Elezovic.

Bug introduced by commit e42375fc8, so back-patch to 9.5 as that was.

Fix by David Rowley, regression test by Michael Paquier

Discussion: https://postgr.es/m/DB6PR03MB30775D58E732D4EB0C13725B9AE00@DB6PR03MB3077.eurprd03.prod.outlook.com
src/backend/commands/tablecmds.c
src/test/regress/expected/alter_table.out
src/test/regress/sql/alter_table.sql