]> granicus.if.org Git - postgresql/commit
GIN's ItemPointerIsMin, ItemPointerIsMax, and ItemPointerIsLossyPage macros
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 5 Jun 2009 18:50:52 +0000 (18:50 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 5 Jun 2009 18:50:52 +0000 (18:50 +0000)
commitb2ec4f2ad6e82a14b12ca2ccf1ac4b14265b280e
tree221547102ad92a35d9448ba18e6483235a18d917
parent101430d2919fbfdf11054898d1f2260955560327
GIN's ItemPointerIsMin, ItemPointerIsMax, and ItemPointerIsLossyPage macros
should use GinItemPointerGetBlockNumber/GinItemPointerGetOffsetNumber,
not ItemPointerGetBlockNumber/ItemPointerGetOffsetNumber, because the latter
will Assert() on ip_posid == 0, ie a "Min" pointer.  (Thus, ItemPointerIsMin
has never worked at all, but it seems unused at present.)  I'm not certain
that the case can occur in normal functioning, but it's blowing up on me
while investigating Tatsuo-san's data corruption problem.  In any case it
seems like a problem waiting to bite someone.

Back-patch just in case this really is a problem for somebody in the field.
src/include/access/gin.h