]> granicus.if.org Git - python/commit
platform: use subprocess.Popen() instead of os.popen() in _syscmd_file()
authorVictor Stinner <victor.stinner@haypocalc.com>
Sun, 18 Apr 2010 09:07:49 +0000 (09:07 +0000)
committerVictor Stinner <victor.stinner@haypocalc.com>
Sun, 18 Apr 2010 09:07:49 +0000 (09:07 +0000)
commitb2a0a434a83ef94f5b0b72ed1465be2ca967439e
tree74f7d12cd9139c864aeff281c43be2f1af56f41b
parent24f09fdb230c346303aef15b25f31fdb8cb431db
platform: use subprocess.Popen() instead of os.popen() in _syscmd_file()

 * Popen() avoids ugly shell escape: target.replace('"', '\\"')
 * Use proc.communicate() instead of f.stdout.read()
 * Get output from stdout by splitting with ": " instead of splitting by spaces
   to support filename with spaces
Lib/platform.py