]> granicus.if.org Git - php/commit
Fix failed tests for phar
authorPeter Kokot <peterkokot@gmail.com>
Sat, 20 Jul 2019 22:49:35 +0000 (00:49 +0200)
committerPeter Kokot <peterkokot@gmail.com>
Sat, 20 Jul 2019 22:49:35 +0000 (00:49 +0200)
commitb1643e166d039057cdefb9a5a5420d165f2b2e05
tree8dbf9d1ddce4c4053687cc9607e5a303b0b3d633
parentf5227c5863a79cb219902f32aaebacac77a6e133
Fix failed tests for phar

- when $status is boolean, E_NOTICE appears and tests fail
- opcache is never enabled on these tests anyway.
- Add opcache.revalidate_freq=0 to testing script

  Instead of checking this in the tests files it can be used directly in
  the main testing script. Also this fixes failed tests.

- Use opcache_invalidate() instead of sleep() delay in some tests. Some
  delays are still used since the opcache_invalidate seems to be buggy
  and not working as expected.

Closes GH-4392
ext/phar/tests/create_new_and_modify.phpt
ext/phar/tests/delete_in_phar.phpt
ext/phar/tests/delete_in_phar_confirm.phpt
ext/phar/tests/tar/create_new_and_modify.phpt
ext/phar/tests/tar/delete_in_phar.phpt
ext/phar/tests/tar/delete_in_phar_confirm.phpt
ext/phar/tests/zip/create_new_and_modify.phpt
ext/phar/tests/zip/delete_in_phar.phpt
ext/phar/tests/zip/delete_in_phar_confirm.phpt
run-tests.php