]> granicus.if.org Git - postgresql/commit
Improve pg_regress's error reporting for schedule-file problems.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 7 Oct 2017 22:04:25 +0000 (18:04 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 7 Oct 2017 22:04:25 +0000 (18:04 -0400)
commitb11f0d36b224a9673863b4e592f40f179dba3016
tree58f16dfafcb41cba8953deffe5f01c815dc18149
parentef73a8162a5fe9c4b2f895bf9fb660f1aabc796c
Improve pg_regress's error reporting for schedule-file problems.

The previous coding here trashed the line buffer as it scanned it,
making it impossible to print the source line in subsequent error
messages.  With a few save/restore/strdup pushups we can improve
that situation.

In passing, move the free'ing of the various strings that are collected
while processing one set of tests down to the bottom of the loop.
That's simpler, less surprising, and should make valgrind less unhappy
about the strings that were previously leaked by the last iteration.
src/test/regress/pg_regress.c