]> granicus.if.org Git - postgresql/commit
Don't pass an invalid file handle to dup2(). That causes a crash on
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 1 Apr 2010 20:12:28 +0000 (20:12 +0000)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 1 Apr 2010 20:12:28 +0000 (20:12 +0000)
commitb0a3d7e47cdff59f363361798b920ba7cb73f447
tree836033b54f2eda5c26303da979fe8fa0039fc023
parent9b69647824b8ceb4c2bc1b9127f5faf5f2a70129
Don't pass an invalid file handle to dup2(). That causes a crash on
Windows, thanks to a feature in CRT called Parameter Validation.

Backpatch to 8.2, which is the oldest version supported on Windows. In
8.2 and 8.3 also backpatch the earlier change to use DEVNULL instead of
NULL_DEV #define for a /dev/null-like device. NULL_DEV was hard-coded to
"/dev/null" regardless of platform, which didn't work on Windows, while
DEVNULL works on all platforms. Restarting syslogger didn't work on
Windows on versions 8.3 and below because of that.
src/backend/postmaster/syslogger.c