]> granicus.if.org Git - clang/commit
[Driver] Add an option for createInvocationFromCommandLine to recover on errors
authorIlya Biryukov <ibiryukov@google.com>
Tue, 27 Aug 2019 10:02:18 +0000 (10:02 +0000)
committerIlya Biryukov <ibiryukov@google.com>
Tue, 27 Aug 2019 10:02:18 +0000 (10:02 +0000)
commitaef9ce4a19f9fcb73f5af966544cd461f0007240
treecbe118125f08cf6cf19e218c83cd90533ecd9544
parent82826b06c65faa794af55367e9d51a46e8284c11
[Driver] Add an option for createInvocationFromCommandLine to recover on errors

Summary:
Previously, it would always return nullptr on any error.
This change adds a parameter, controlling whether the function should
attempt to return a non-null result even if unknown arguments (or other
errors were encountered).

The new behavior is only used in clangd.

Considered an alternative of changing the return value instead of adding
a new parameter, but that would require updating all callsites. Settled
with the parameter to minimize the code changes.

Reviewers: gribozavr

Reviewed By: gribozavr

Subscribers: nridge, jkorous, arphaman, kadircet, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D66731

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@370033 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/Frontend/CompilerInvocation.h
include/clang/Frontend/Utils.h
lib/Frontend/CreateInvocationFromCommandLine.cpp