]> granicus.if.org Git - postgresql/commit
Fix jit compilation bug on wide tables.
authorAndres Freund <andres@anarazel.de>
Tue, 27 Nov 2018 18:07:43 +0000 (10:07 -0800)
committerAndres Freund <andres@anarazel.de>
Tue, 27 Nov 2018 18:07:43 +0000 (10:07 -0800)
commitaee085bc018ffb961bf0a2c3ac72a45bb3aa33a9
tree9d509cb312c68e63a98997a0d27ce48bc017419b
parent5ef8f08b541da5df1ac00a3c880578a8e3bf447c
Fix jit compilation bug on wide tables.

The function generated to perform JIT compiled tuple deforming failed
when HeapTupleHeader's t_hoff was bigger than a signed int8. I'd
failed to realize that LLVM's getelementptr would treat an int8 index
argument as signed, rather than unsigned.  That means that a hoff
larger than 127 would result in a negative offset being applied.  Fix
that by widening the index to 32bit.

Add a testcase with a wide table. Don't drop it, as it seems useful to
verify other tools deal properly with wide tables.

Thanks to Justin Pryzby for both reporting a bug and then reducing it
to a reproducible testcase!

Reported-By: Justin Pryzby
Author: Andres Freund
Discussion: https://postgr.es/m/20181115223959.GB10913@telsasoft.com
Backpatch: 11, just as jit compilation was
src/backend/jit/llvm/llvmjit_deform.c
src/test/regress/expected/create_table.out
src/test/regress/expected/sanity_check.out
src/test/regress/sql/create_table.sql