]> granicus.if.org Git - python/commit
Fix the refleak in strftime when converting a %Z with a user defined tzinfo.
authorNeal Norwitz <nnorwitz@gmail.com>
Sun, 12 Aug 2007 04:32:26 +0000 (04:32 +0000)
committerNeal Norwitz <nnorwitz@gmail.com>
Sun, 12 Aug 2007 04:32:26 +0000 (04:32 +0000)
commitaea70e03c40eeb80657c36275dcd843356b0b7fa
tree79e5e3df3f6b693003d5d65379fa644a7582f3b0
parentcbbe98f04fb03922ff2e3b6bf35769cf63673153
Fix the refleak in strftime when converting a %Z with a user defined tzinfo.
I inverted some of the conditionals to reduce indent levels.  Hopefully
this makes it a little easier to read.

This code caused the leak:

    class FixedOffset(datetime.tzinfo):
        def tzname(self, dt): return "UTC"

    datetime.time(12, 47, tzinfo=FixedOffset()).strftime('%Z')

This code is very tricky and I'm not positive it works.  However,
it neither crashes nor leaks.
Modules/datetimemodule.c