]> granicus.if.org Git - postgresql/commit
Make the world very nearly safe for composite-type columns in tables.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 5 Jun 2004 01:55:05 +0000 (01:55 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 5 Jun 2004 01:55:05 +0000 (01:55 +0000)
commitae93e5fd6e8a7e2321e87d23165d9d7660cde598
treea8e22c4835283c61e137285ba2dabfe3feead1a9
parent8f2ea8b7b53a02078ba0393e6892ac5356a3631e
Make the world very nearly safe for composite-type columns in tables.
1. Solve the problem of not having TOAST references hiding inside composite
values by establishing the rule that toasting only goes one level deep:
a tuple can contain toasted fields, but a composite-type datum that is
to be inserted into a tuple cannot.  Enforcing this in heap_formtuple
is relatively cheap and it avoids a large increase in the cost of running
the tuptoaster during final storage of a row.
2. Fix some interesting problems in expansion of inherited queries that
reference whole-row variables.  We never really did this correctly before,
but it's now relatively painless to solve by expanding the parent's
whole-row Var into a RowExpr() selecting the proper columns from the
child.
If you dike out the preventive check in CheckAttributeType(),
composite-type columns now seem to actually work.  However, we surely
cannot ship them like this --- without I/O for composite types, you
can't get pg_dump to dump tables containing them.  So a little more
work still to do.
12 files changed:
src/backend/access/common/heaptuple.c
src/backend/access/heap/tuptoaster.c
src/backend/optimizer/path/allpaths.c
src/backend/optimizer/path/costsize.c
src/backend/optimizer/path/pathkeys.c
src/backend/optimizer/prep/prepunion.c
src/backend/optimizer/util/relnode.c
src/backend/optimizer/util/tlist.c
src/backend/utils/cache/typcache.c
src/include/access/tuptoaster.h
src/include/nodes/relation.h
src/include/utils/typcache.h