]> granicus.if.org Git - postgresql/commit
Fix incorrect computations of length of null bitmap in pageinspect.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 4 Jan 2018 19:59:00 +0000 (14:59 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 4 Jan 2018 19:59:00 +0000 (14:59 -0500)
commitad592f4a6eed64358bf1ec8733c4f0be2a3c85dd
tree998ea8d9845c759b5a2bde113bd5c4bd6bc42470
parent2157a61b5aa3805a9e0fb11fa2fd4da9ca54234c
Fix incorrect computations of length of null bitmap in pageinspect.

Instead of using our standard macro for this calculation, this code
did it itself ... and got it wrong, leading to incorrect display of
the null bitmap in some cases.  Noted and fixed by Maksim Milyutin.

In passing, remove a uselessly duplicative error check.

Errors were introduced in commit d6061f83a; back-patch to 9.6
where that came in.

Maksim Milyutin, reviewed by Andrey Borodin

Discussion: https://postgr.es/m/ec295792-a69f-350f-6287-25a20e8f31d5@gmail.com
contrib/pageinspect/heapfuncs.c