]> granicus.if.org Git - postgresql/commit
Fix plan created for inherited UPDATE/DELETE with all tables excluded.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 22 Feb 2019 17:23:00 +0000 (12:23 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 22 Feb 2019 17:23:19 +0000 (12:23 -0500)
commitab5fcf2b04f9cc4ecccb1832faabadb047087d23
tree39713b182d2a0034568bec476e562b5010f28f2b
parent98098faaff77a632c759c967f3b956524e492ee4
Fix plan created for inherited UPDATE/DELETE with all tables excluded.

In the case where inheritance_planner() finds that every table has
been excluded by constraints, it thought it could get away with
making a plan consisting of just a dummy Result node.  While certainly
there's no updating or deleting to be done, this had two user-visible
problems: the plan did not report the correct set of output columns
when a RETURNING clause was present, and if there were any
statement-level triggers that should be fired, it didn't fire them.

Hence, rather than only generating the dummy Result, we need to
stick a valid ModifyTable node on top, which requires a tad more
effort here.

It's been broken this way for as long as inheritance_planner() has
known about deleting excluded subplans at all (cf commit 635d42e9c),
so back-patch to all supported branches.

Amit Langote and Tom Lane, per a report from Petr Fedorov.

Discussion: https://postgr.es/m/5da6f0f0-1364-1876-6978-907678f89a3e@phystech.edu
src/backend/optimizer/plan/planner.c
src/test/regress/expected/inherit.out
src/test/regress/expected/triggers.out
src/test/regress/sql/inherit.sql
src/test/regress/sql/triggers.sql