]> granicus.if.org Git - postgresql/commit
Handle table_complete_speculative's succeeded argument as documented.
authorAndres Freund <andres@anarazel.de>
Tue, 14 May 2019 19:11:26 +0000 (12:11 -0700)
committerAndres Freund <andres@anarazel.de>
Tue, 14 May 2019 19:19:32 +0000 (12:19 -0700)
commitaa4b8c61d2cd57b53be03defb04d59b232a0e150
tree3b7b1ca7702d20a11c652e876e666489f2d84996
parent08e2edc0767ab6e619970f165cb34d4673105f23
Handle table_complete_speculative's succeeded argument as documented.

For some reason both callsite and the implementation for heapam had
the meaning inverted (i.e. succeeded == true was passed in case of
conflict). That's confusing.

I (Andres) briefly pondered whether it'd be better to rename
table_complete_speculative's argument to 'bool specConflict' or such,
but decided not to. The 'complete' in the function name for me makes
`succeeded` sound a bit better.

Reported-By: Ashwin Agrawal, Melanie Plageman, Heikki Linnakangas
Discussion:
   https://postgr.es/m/CALfoeitk7-TACwYv3hCw45FNPjkA86RfXg4iQ5kAOPhR+F1Y4w@mail.gmail.com
   https://postgr.es/m/97673451-339f-b21e-a781-998d06b1067c@iki.fi
src/backend/access/heap/heapam_handler.c
src/backend/executor/nodeModifyTable.c