]> granicus.if.org Git - postgresql/commit
Fix unportable shell-script syntax in pg_upgrade's test.sh.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 17 Mar 2014 01:55:06 +0000 (21:55 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 17 Mar 2014 01:55:32 +0000 (21:55 -0400)
commita98ad4fabc414c821bfb273f334a5bbccf4a451a
tree4606038d07740a4d47fcc9a541a7f22512715e31
parent37e5b3d9bd97b1eb898df95c969f064ea3ce729d
Fix unportable shell-script syntax in pg_upgrade's test.sh.

I discovered the hard way that on some old shells, the locution
    FOO=""   unset FOO
does not behave the same as
    FOO="";  unset FOO
and in fact leaves FOO set to an empty string.  test.sh was inconsistently
spelling it different ways on adjacent lines.

This got broken relatively recently, in commit c737a2e56, so the lack of
field reports to date doesn't represent a lot of evidence that the problem
is rare.
contrib/pg_upgrade/test.sh