]> granicus.if.org Git - postgresql/commit
Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Dec 2012 19:07:42 +0000 (14:07 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 23 Dec 2012 19:07:42 +0000 (14:07 -0500)
commita91c411772fdc9708c535e78d6fec26eacd45b24
treebfb78eb00f49b20a7c02d5850f90fb581e22cd4b
parente5e8ad3df5245cbed7f54674ed2cca596a7f55d6
Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.

transformExpr() is required to cope with already-transformed expression
trees, for various ugly-but-not-quite-worth-cleaning-up reasons.  However,
some of its newer subroutines hadn't gotten the memo.  This accounts for
bug #7763 from Norbert Buchmuller: transformRowExpr() was overwriting the
previously determined type of a RowExpr during CREATE TABLE LIKE INCLUDING
INDEXES.  Additional investigation showed that transformXmlExpr had the
same kind of problem, but all the other cases seem to be safe.

Andres Freund and Tom Lane
src/backend/parser/gram.y
src/backend/parser/parse_expr.c