]> granicus.if.org Git - postgresql/commit
Don't allow foreign tables with OIDs.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 24 Jun 2014 09:31:36 +0000 (12:31 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 24 Jun 2014 10:27:18 +0000 (13:27 +0300)
commita87a7dc8b64a99e5e497591dddb37b3ecdfae2eb
tree667c0774049661389893126ab35458a52ed87ce2
parentc922353b1c7e7fe5fa506664ccf0c87a0abfdda2
Don't allow foreign tables with OIDs.

The syntax doesn't let you specify "WITH OIDS" for foreign tables, but it
was still possible with default_with_oids=true. But the rest of the system,
including pg_dump, isn't prepared to handle foreign tables with OIDs
properly.

Backpatch down to 9.1, where foreign tables were introduced. It's possible
that there are databases out there that already have foreign tables with
OIDs. There isn't much we can do about that, but at least we can prevent
them from being created in the future.

Patch by Etsuro Fujita, reviewed by Hadi Moshayedi.
src/backend/commands/tablecmds.c