]> granicus.if.org Git - postgresql/commit
Properly initialize SortSupport for ORDER BY rechecks in nodeIndexscan.c.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 5 Jun 2016 15:53:06 +0000 (11:53 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 5 Jun 2016 15:53:06 +0000 (11:53 -0400)
commita7aa61ffe7ed12cf8d5cbdfc887900549f9ed354
treec889756c49dbbb62c50727f5257049b3591530fb
parentc82037e372394ee046e278887c8f938591ca7406
Properly initialize SortSupport for ORDER BY rechecks in nodeIndexscan.c.

Fix still another bug in commit 35fcb1b3d: it failed to fully initialize
the SortSupport states it introduced to allow the executor to re-check
ORDER BY expressions containing distance operators.  That led to a null
pointer dereference if the sortsupport code tried to use ssup_cxt.  The
problem only manifests in narrow cases, explaining the lack of previous
field reports.  It requires a GiST-indexable distance operator that lacks
SortSupport and is on a pass-by-ref data type, which among core+contrib
seems to be only btree_gist's interval opclass; and it requires the scan
to be done as an IndexScan not an IndexOnlyScan, which explains how
btree_gist's regression test didn't catch it.  Per bug #14134 from
Jihyun Yu.

Peter Geoghegan

Report: <20160511154904.2603.43889@wrigleys.postgresql.org>
contrib/btree_gist/expected/interval.out
contrib/btree_gist/sql/interval.sql
src/backend/executor/nodeIndexscan.c