]> granicus.if.org Git - postgresql/commit
Show ignored constants as "$N" rather than "?" in pg_stat_statements.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 28 Mar 2017 00:14:36 +0000 (20:14 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 28 Mar 2017 00:14:36 +0000 (20:14 -0400)
commita6f22e83562d8b78293229587cd3d9430d16d466
tree4cf6ed5b8176a64dc6cf06912ef6525093b82b2a
parent6462238f0d7b7c15eb3f54c2108573cee8fb24ba
Show ignored constants as "$N" rather than "?" in pg_stat_statements.

The trouble with the original choice here is that "?" is a valid (and
indeed used) operator name, so that you could end up with ambiguous
statement texts like "SELECT ? ? ?".  With this patch, you instead
see "SELECT $1 ? $2", which seems significantly more readable.
The numbers used for this purpose begin after the last actual $N parameter
in the particular query.  The conflict with external parameters has its own
potential for confusion of course, but it was agreed to be an improvement
over the previous behavior.

Lukas Fittl

Discussion: https://postgr.es/m/CAP53PkxeaCuwYmF-A4J5z2-qk5fYFo5_NH3gpXGJJBxv1DMwEw@mail.gmail.com
contrib/pg_stat_statements/expected/pg_stat_statements.out
contrib/pg_stat_statements/pg_stat_statements.c
contrib/pg_stat_statements/sql/pg_stat_statements.sql
doc/src/sgml/pgstatstatements.sgml