]> granicus.if.org Git - python/commit
bpo-34022: Stop forcing of hash-based invalidation with SOURCE_DATE_EPOCH (GH-9607)
authorElvis Pranskevichus <elvis@magic.io>
Wed, 10 Oct 2018 16:43:14 +0000 (12:43 -0400)
committerVictor Stinner <vstinner@redhat.com>
Wed, 10 Oct 2018 16:43:14 +0000 (18:43 +0200)
commita6b3ec5b6d4f6387820fccc570eea08b9615620d
tree0a4cda67f41ce3e6237f4614c890e73d666e69b5
parent7e18deef652a9d413d5dbd19d61073ba7eb5460e
bpo-34022: Stop forcing of hash-based invalidation with SOURCE_DATE_EPOCH (GH-9607)

Unconditional forcing of ``CHECKED_HASH`` invalidation was introduced in
3.7.0 in bpo-29708.  The change is bad, as it unconditionally overrides
*invalidation_mode*, even if it was passed as an explicit argument to
``py_compile.compile()`` or ``compileall``.  An environment variable
should *never* override an explicit argument to a library function.
That change leads to multiple test failures if the ``SOURCE_DATE_EPOCH``
environment variable is set.

This changes ``py_compile.compile()`` to only look at
``SOURCE_DATE_EPOCH`` if no explicit *invalidation_mode* was specified.
I also made various relevant tests run with explicit control over the
value of ``SOURCE_DATE_EPOCH``.

While looking at this, I noticed that ``zipimport`` does not work
with hash-based .pycs _at all_, though I left the fixes for
subsequent commits.
Doc/library/compileall.rst
Doc/library/py_compile.rst
Lib/compileall.py
Lib/py_compile.py
Lib/test/test_compileall.py
Lib/test/test_importlib/source/test_file_loader.py
Lib/test/test_py_compile.py
Misc/NEWS.d/next/Library/2018-09-27-13-14-15.bpo-34022.E2cl0r.rst [new file with mode: 0644]