]> granicus.if.org Git - postgresql/commit
Simplify index_[constraint_]create API
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 14 Nov 2017 14:19:05 +0000 (15:19 +0100)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 14 Nov 2017 14:19:05 +0000 (15:19 +0100)
commita61f5ab986386628cf20b33971364475ce452412
tree2026092ae3ae8a9269015198b41e97bffc2589ee
parent591c504fad0de88b559bf28e929d23672179a857
Simplify index_[constraint_]create API

Instead of passing large swaths of boolean arguments, define some flags
that can be used in a bitmask.  This makes it easier not only to figure
out what each call site is doing, but also to add some new flags.

The flags are split in two -- one set for index_create directly and
another for constraints.  index_create() itself receives both, and then
passes down the latter to index_constraint_create(), which can also be
called standalone.

Discussion: https://postgr.es/m/20171023151251.j75uoe27gajdjmlm@alvherre.pgsql
Reviewed-by: Simon Riggs
src/backend/catalog/index.c
src/backend/catalog/toasting.c
src/backend/commands/indexcmds.c
src/backend/commands/tablecmds.c
src/include/catalog/index.h