]> granicus.if.org Git - postgresql/commit
Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 15 Feb 2011 20:50:11 +0000 (15:50 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 15 Feb 2011 20:50:11 +0000 (15:50 -0500)
commita580bffa08861dcbb25fb63c89654a9695484b4c
treee9e4979352a0c311bb6fd1c39556c279dda1d3e3
parent666407566dfb9ab585cc66bd1c0eb5ba37e0cf30
Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.

Recent releases had a check on rel->rd_refcnt in heap_drop_with_catalog,
but failed to cover the possibility of pending trigger events at DROP time.
(Before 8.4 we didn't even check the refcnt.)  When the trigger events were
eventually fired, you'd get "could not open relation with OID nnn" errors,
as in recent report from strk.  Better to throw a suitable error when the
DROP is attempted.

Also add a similar check in DROP INDEX.

Back-patch to all supported branches.
src/backend/catalog/heap.c
src/backend/catalog/index.c