]> granicus.if.org Git - python/commit
bpo-31933: fix blake2 multi-byte params on big endian platforms (GH-4250) (#4262)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Fri, 3 Nov 2017 19:55:54 +0000 (12:55 -0700)
committerChristian Heimes <christian@python.org>
Fri, 3 Nov 2017 19:55:54 +0000 (20:55 +0100)
commita512493371a073e252a2e52b445aa2d66ddca7cb
treeb2aaa4eb48e135716f0b882c88adde3b5be51b5f
parentea80ae04e2ec68c7e289048d3224a24b3c3fb107
bpo-31933: fix blake2 multi-byte params on big endian platforms (GH-4250) (#4262)

All Blake2 params have to be encoded in little-endian byte order. For
the two multi-byte integer params, leaf_length and node_offset, that
means that assigning a native-endian integer to them appears to work on
little-endian platforms, but gives the wrong result on big-endian. The
current libb2 API doesn't make that very clear, and @sneves is working
on new API functions in the GH issue above. In the meantime, we can work
around the problem by explicitly assigning little-endian values to the
parameter block.

See https://github.com/BLAKE2/libb2/issues/12.
(cherry picked from commit dcfb0e3c04f1b29a0d09bb0a81dcd5ee5a5fef1a)
Lib/test/test_hashlib.py
Misc/NEWS.d/next/Library/2017-11-03-08-36-03.bpo-31933.UrtoMP.rst [new file with mode: 0644]
Modules/_blake2/blake2b_impl.c
Modules/_blake2/blake2s_impl.c