]> granicus.if.org Git - icinga2/commit
HttpServerConnection: Prefer error codes over Boost exceptions 7477/head
authorMichael Friedrich <michael.friedrich@icinga.com>
Fri, 6 Sep 2019 08:06:17 +0000 (10:06 +0200)
committerMichael Friedrich <michael.friedrich@icinga.com>
Fri, 6 Sep 2019 08:06:17 +0000 (10:06 +0200)
commita208f7baf039c8ec7322fd18144871b9e95ae847
treec6f4ac15b6a03b8d6af8e34a980715592d959d9d
parent1f50a705f9c30d3267570ade068185e281aaee63
HttpServerConnection: Prefer error codes over Boost exceptions

When run within a coroutine, exceptions on Windows may influence
bad behaviour here. Instead, we'll check for the error code
and extract the message from memory. In contrast to exceptions
which are stored on the stack frame and then return, this costs
a little more memory but simplifies the logic.

This doesn't fix the linked issue, but is related to the analysis.

refs #7431
lib/remote/httpserverconnection.cpp