]> granicus.if.org Git - postgresql/commit
Fix COPY FROM for null marker strings that correspond to invalid encoding.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 26 Mar 2012 03:17:27 +0000 (23:17 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 26 Mar 2012 03:17:27 +0000 (23:17 -0400)
commit9f0a01707607e476ac3a89854777cdba76e0ff37
tree9cd930ef4e9fcf2f0046694496364427b9618702
parent811a2cbc167bfef4e5a88d468d5258385318ad87
Fix COPY FROM for null marker strings that correspond to invalid encoding.

The COPY documentation says "COPY FROM matches the input against the null
string before removing backslashes".  It is therefore reasonable to presume
that null markers like E'\\0' will work ... and they did, until someone put
the tests in the wrong order during microoptimization-driven rewrites.
Since then, we've been failing if the null marker is something that would
de-escape to an invalidly-encoded string.  Since null markers generally
need to be something that can't appear in the data, this represents a
nontrivial loss of functionality; surprising nobody noticed it earlier.

Per report from Jeff Davis.  Backpatch to 8.4 where this got broken.
src/backend/commands/copy.c
src/test/regress/expected/copy2.out
src/test/regress/sql/copy2.sql