]> granicus.if.org Git - postgresql/commit
Improve handling of INT_MIN / -1 and related cases.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 20 Nov 2012 02:21:54 +0000 (21:21 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 20 Nov 2012 02:21:54 +0000 (21:21 -0500)
commit9e74c02259f4bdd77a35c2e2547fd78a8ec41552
tree29ad7c4b8ea7dcdbebcbcfe1e2059af3d7045f64
parent73af46e82c501ec9122fd27c39c709f1d6fecc17
Improve handling of INT_MIN / -1 and related cases.

Some platforms throw an exception for this division, rather than returning
a necessarily-overflowed result.  Since we were testing for overflow after
the fact, an exception isn't nice.  We can avoid the problem by treating
division by -1 as negation.

Add some regression tests so that we'll find out if any compilers try to
optimize away the overflow check conditions.

Back-patch of commit 1f7cb5c30983752ff8de833de30afcaee63536d0.

Per discussion with Xi Wang, though this is different from the patch he
submitted.
src/backend/utils/adt/int.c
src/backend/utils/adt/int8.c
src/test/regress/expected/int2.out
src/test/regress/expected/int4.out
src/test/regress/expected/int8-exp-three-digits.out
src/test/regress/expected/int8.out
src/test/regress/sql/int2.sql
src/test/regress/sql/int4.sql
src/test/regress/sql/int8.sql