]> granicus.if.org Git - zfs/commit
Write label 2,3 uberblocks when vdev expands
authorOlaf Faaland <faaland1@llnl.gov>
Tue, 2 May 2017 20:55:24 +0000 (13:55 -0700)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Tue, 2 May 2017 20:55:24 +0000 (13:55 -0700)
commit9d3f7b87919b7d0d869153ca72844f565cd0bf52
treecdfb1aae9160c70ad29405d39cff1a5fb8ba7607
parente7fbeb606a18b9f04daadddc19b9c4f9a9b34841
Write label 2,3 uberblocks when vdev expands

When vdev_psize increases, the location of labels 2 and 3 changes
because their location is relative to the end of the device.

The configs for labels 2 and 3 are written during the next spa_sync()
because the vdev is added to the dirty config list.  However, the
uberblock rings are not re-written in their new location, leaving the
device vulnerable to the beginning of the device being overwritten or
damaged.

This patch copies the uberblock ring from label 0 to labels 2 and 3,
in their new locations, at the next sync after vdev_psize increases.

Also, add a test zpool_expand_004_pos.ksh to confirm the uberblocks
are copied.

Reviewed-by: BearBabyLiu <liu.huang@zte.com.cn>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Closes #5108
include/sys/vdev_impl.h
module/zfs/vdev.c
module/zfs/vdev_label.c
tests/runfiles/linux.run
tests/zfs-tests/tests/functional/cli_root/zpool_expand/Makefile.am
tests/zfs-tests/tests/functional/cli_root/zpool_expand/zpool_expand_004_pos.ksh [new file with mode: 0755]