]> granicus.if.org Git - postgresql/commit
Fix mishandling of system columns in FDW queries.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 22 Nov 2014 21:01:05 +0000 (16:01 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 22 Nov 2014 21:01:05 +0000 (16:01 -0500)
commit9c58101117d25f174c8d8013befdc33c632922d0
tree47ee2ed4617154f9cd5504fad9df6004aa1e4c08
parenteca2b9ba3e1e65c2ac880578bfb3cbeed1cb1d26
Fix mishandling of system columns in FDW queries.

postgres_fdw would send query conditions involving system columns to the
remote server, even though it makes no effort to ensure that system
columns other than CTID match what the remote side thinks.  tableoid,
in particular, probably won't match and might have some use in queries.
Hence, prevent sending conditions that include non-CTID system columns.

Also, create_foreignscan_plan neglected to check local restriction
conditions while determining whether to set fsSystemCol for a foreign
scan plan node.  This again would bollix the results for queries that
test a foreign table's tableoid.

Back-patch the first fix to 9.3 where postgres_fdw was introduced.
Back-patch the second to 9.2.  The code is probably broken in 9.1 as
well, but the patch doesn't apply cleanly there; given the weak state
of support for FDWs in 9.1, it doesn't seem worth fixing.

Etsuro Fujita, reviewed by Ashutosh Bapat, and somewhat modified by me
contrib/postgres_fdw/deparse.c
contrib/postgres_fdw/expected/postgres_fdw.out
contrib/postgres_fdw/sql/postgres_fdw.sql
src/backend/optimizer/plan/createplan.c