]> granicus.if.org Git - clang/commit
Merging r322901:
authorHans Wennborg <hans@hanshq.net>
Fri, 19 Jan 2018 10:09:28 +0000 (10:09 +0000)
committerHans Wennborg <hans@hanshq.net>
Fri, 19 Jan 2018 10:09:28 +0000 (10:09 +0000)
commit9b9bcde7d76d787d74290b64ffaf996aca0a905b
treeece54b387756cc10985b0eb0d94acd299621650f
parent23060de2a4992a01742d2c85bedff7d0e5131fab
Merging r322901:
------------------------------------------------------------------------
r322901 | nico | 2018-01-18 13:40:27 -0800 (Thu, 18 Jan 2018) | 19 lines

Remove TautologicalInRangeCompare from Extra and TautologicalCompare.

This removes the following (already default-off) warnings from -Wextra:
  -Wtautological-type-limit-compare,
  -Wtautological-unsigned-zero-compare
  -Wtautological-unsigned-enum-zero-compare

On the thread "[cfe-dev] -Wtautological-constant-compare issues", clang
code owners Richard Smith, John McCall, and Reid Kleckner as well as
libc++ code owner Marshall Clow stated that these new warnings are not
yet ready for prime time and shouldn't be part of -Wextra.

Furthermore, Vedant Kumar (Apple), Peter Hosek (Fuchsia), and me (Chromium)
expressed the same concerns (Vedant on that thread, Peter on
https://reviews.llvm.org/D39462, me on https://reviews.llvm.org/D41512).

So remove them from -Wextra, and remove TautologicalInRangeCompare from
TautologicalCompare too until they're usable with real-world code.

------------------------------------------------------------------------

git-svn-id: https://llvm.org/svn/llvm-project/cfe/branches/release_60@322931 91177308-0d34-0410-b5e6-96231b3b80d8
include/clang/Basic/DiagnosticGroups.td
test/Sema/tautological-constant-compare.c